protocol adapters: e2e test, nodom binary, and bump worker-dom.#29541
Merged
samouri merged 4 commits intoampproject:masterfrom Aug 3, 2020
Merged
protocol adapters: e2e test, nodom binary, and bump worker-dom.#29541samouri merged 4 commits intoampproject:masterfrom
samouri merged 4 commits intoampproject:masterfrom
Conversation
samouri
changed the title
samouri
commented
Jul 29, 2020
samouri
commented
Jul 29, 2020
dreamofabear
approved these changes
Jul 30, 2020
Member
Author
|
@jridgewell: can I get your review for |
jridgewell
approved these changes
Jul 30, 2020
- adds support for nodom flag to amp-script, for protocol adapters. - upgrades worker-dom to the latest (which has support for callFunction, and lite binaries). - adds e2e test for "script" uri in amp-list.
1 task
ed-bird
pushed a commit
to ed-bird/amphtml
that referenced
this pull request
Dec 10, 2020
…roject#29541) * amp-script: nodom variant - adds support for nodom flag to amp-script, for protocol adapters. - upgrades worker-dom to the latest (which has support for callFunction, and lite binaries). - adds e2e test for "script" uri in amp-list. * lint * force nodom to not have width/height. * 2019 --> 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
nodombuild support.<amp-script>, yielding a tiny worker bundle size and 0 size requirement.next step