Skip to content

Rewind last story page on visibilitystate inactive.#29704

Merged
gmajoulet merged 1 commit intoampproject:masterfrom
gmajoulet:rewind_last_page_on_inactive
Aug 7, 2020
Merged

Rewind last story page on visibilitystate inactive.#29704
gmajoulet merged 1 commit intoampproject:masterfrom
gmajoulet:rewind_last_page_on_inactive

Conversation

@gmajoulet
Copy link
Contributor

Rewind last story page on visibilitystate inactive, ie: when document is swiped away.

Fixes #28927
Fixes #28650

@gmajoulet gmajoulet requested review from Enriqe and mszylkowski August 5, 2020 23:50
@google-cla google-cla bot added the cla: yes label Aug 5, 2020
@amp-owners-bot
Copy link

amp-owners-bot bot commented Aug 5, 2020

Hey @newmuis, @Enriqe! These files were changed:

extensions/amp-story/1.0/amp-story.js
extensions/amp-story/1.0/test/test-amp-story.js

@gmajoulet
Copy link
Contributor Author

Friendly ping

Copy link
Contributor

@mszylkowski mszylkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Feel free to ping me if I don't see the GH emails

@gmajoulet gmajoulet merged commit b8d4d30 into ampproject:master Aug 7, 2020
ed-bird pushed a commit to ed-bird/amphtml that referenced this pull request Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Swiping back to a story should restart its active page Story media performance last page metrics not sending

3 participants