🧪 Enable build-in-chunks experiment in canary-config.json#30301
Merged
kevinkimball merged 1 commit intoampproject:masterfrom Sep 22, 2020
Merged
🧪 Enable build-in-chunks experiment in canary-config.json#30301kevinkimball merged 1 commit intoampproject:masterfrom
kevinkimball merged 1 commit intoampproject:masterfrom
Conversation
jridgewell
approved these changes
Sep 18, 2020
Member
|
I think you could test on amp.dev today with |
Contributor
Author
|
@samouri Yes, tested some locally and it seems to be a big improvement. Want to get data so we can feel comfortable rolling out completely. |
Contributor
Author
|
@ampproject/build-cop can we skip the Percy test here? Seems erroneous |
Member
One of our hypotheses was that this would drastically improve |
Member
Yep, this is a familiar flaky page. Approved it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables experiment from #28553 to limit number of elements that can be built in a single pass. This issue is affecting amp.dev and causing a long task .