Skip to content

🚮 clean up analytics-chunks experiment#30600

Merged
zhouyx merged 5 commits intoampproject:masterfrom
zhouyx:clean-up-analytics-chunks
Nov 11, 2020
Merged

🚮 clean up analytics-chunks experiment#30600
zhouyx merged 5 commits intoampproject:masterfrom
zhouyx:clean-up-analytics-chunks

Conversation

@zhouyx
Copy link
Contributor

@zhouyx zhouyx commented Oct 9, 2020

No description provided.

@zhouyx zhouyx requested a review from micajuine-ho October 9, 2020 20:15
@google-cla google-cla bot added the cla: yes label Oct 9, 2020
@CLAassistant
Copy link

CLAassistant commented Oct 9, 2020

CLA assistant check
All committers have signed the CLA.

@zhouyx zhouyx force-pushed the clean-up-analytics-chunks branch from 800e23d to 367205c Compare November 9, 2020 21:02
@micajuine-ho
Copy link
Contributor

Thanks for the cleanup!!

@zhouyx zhouyx force-pushed the clean-up-analytics-chunks branch from 4e3b965 to 7b58a59 Compare November 11, 2020 01:39
@zhouyx zhouyx requested a review from estherkim November 11, 2020 03:06
@zhouyx
Copy link
Contributor Author

zhouyx commented Nov 11, 2020

Added @estherkim to approve the fake-dom change

@zhouyx zhouyx merged commit fe036b3 into ampproject:master Nov 11, 2020
@zhouyx zhouyx deleted the clean-up-analytics-chunks branch November 11, 2020 19:20
ed-bird pushed a commit to ed-bird/amphtml that referenced this pull request Dec 10, 2020
* clean up analytics-chunks experiment

* prettify

* fix test

* lint

* fake dom postMessage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants