[amp-story-player] Support poster img from anchor el#33041
Merged
Enriqe merged 1 commit intoampproject:masterfrom Mar 5, 2021
Merged
[amp-story-player] Support poster img from anchor el#33041Enriqe merged 1 commit intoampproject:masterfrom
Enriqe merged 1 commit intoampproject:masterfrom
Conversation
mszylkowski
reviewed
Mar 3, 2021
| const anchorEls = toArray(this.element_.querySelectorAll('a')); | ||
| anchorEls.forEach((element) => { | ||
| const posterImgEl = element.querySelector( | ||
| 'img[data-amp-story-player-poster-img]' |
Contributor
There was a problem hiding this comment.
This shouldn't have the data- in the attribute right (looking at #30753)?
Contributor
Author
There was a problem hiding this comment.
It should, we ended up bikeshedding on the name and changing it do data-* to make it comply with standard HTML spec.
You can verify by looking at the AMP version validator
Contributor
There was a problem hiding this comment.
Oh ok, I had a feeling that data attributes should have a value (not just the empty string) but the documentation seems to be vague on this. LGTM
mszylkowski
approved these changes
Mar 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #30512
Now that #30753 has been merged, we can start supporting using an
<img>tag to declare a poster image for the player.