Improve filter popover usability on mobile#66
Conversation
- Set popover placement to 'top' to avoid overlapping the bottom search bar - Add max-height and overflow-y-auto to make filters scrollable - Add a dedicated close button for better mobile ergonomics - Manage isOpen state to ensure reliable dismissal
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
1 participant
Improved the filter popover's usability on mobile devices by making it scrollable, preventing overlap with the search bar, and adding an easy way to dismiss it.
Key changes:
Filtercomponent insrc/components/filter.tsxto use controlled state.Popover.Contentplacement totop.max-h-[70vh]andoverflow-y-autotoPopover.Dialog.XMarkIconinside the dialog.Popover.Triggerfor the filter button.PR created automatically by Jules for task 7156972356073177233 started by @amrabed