Example of unstable-allowing context manager.#2
Merged
andrewfulton9 merged 1 commit intoJun 3, 2020
Conversation
The advantage of using warnings instead of globals is performance and the ability to also still get the warning printed by default.
Owner
|
How do you think the Zarr core developers will feel about this? Do you think itll make it more likely for them to pull it in? |
Author
|
I don't know, you likely have more experience with them than I. It's just a suggestion on how to have unstable, feature gated functionalities. I'm happy to send that as a separate pull-request to suggest having it if you do not feel comfortable doing so. |
Owner
|
I wonder if it makes sense to put this in a different branch and point to it as an option on the numcodecs PR, and if they are receptive, merge it in? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The advantage of using warnings instead of globals is performance and
the ability to also still get the warning printed by default.