[BUG]: NDK r28's limits.h does not contain LLONG_MAX, LLONG_MIN and other important macros

[thunder-coding]

Description

NDK r27's limits.h contained these important macros, r28 does not have them defined in any of the headers in sysroot.

I did a git bisect that lead to the commit 36f97cac5456a4e3d29ebf8d84ef2ebe03fd0405 in bionic. This bug also is in the main branch of bionic libc

I am using a supported NDK

• I have checked and the NDK I'm using is currently supported

Affected versions

r28

[enh-google]

they should come from clang. @DanAlbert --- is the ndk clang behind the platform clang?

actually, why don't i look myself?

~/Downloads/android-ndk-r28$ cat ./toolchains/llvm/prebuilt/linux-x86_64/lib/clang/19/include/limits.h
.
.
.
/* LONG_LONG_MIN/LONG_LONG_MAX/ULONG_LONG_MAX are a GNU extension.  It's too bad
   that we don't have something like #pragma poison that could be used to
   deprecate a macro - the code should just use LLONG_MAX and friends.
 */
#if defined(__GNU_LIBRARY__) ? defined(__USE_GNU) : !defined(__STRICT_ANSI__)

#undef   LONG_LONG_MIN
#undef   LONG_LONG_MAX
#undef   ULONG_LONG_MAX

#define LONG_LONG_MAX  __LONG_LONG_MAX__
#define LONG_LONG_MIN  (-__LONG_LONG_MAX__-1LL)
#define ULONG_LONG_MAX (__LONG_LONG_MAX__*2ULL+1ULL)
#endif

well, that's unfortunate. this should say

/* LONG_LONG_MIN/LONG_LONG_MAX/ULONG_LONG_MAX are a GNU extension. Android's
   bionic also defines them. It's too bad that we don't have something like
   #pragma poison that could be used to deprecate a macro - the code should just
   use LLONG_MAX and friends.
 */
#if (defined(__GNU_LIBRARY__) ? defined(__USE_GNU)                             \
                              : !defined(__STRICT_ANSI__)) ||                  \
    defined(__BIONIC__)

instead.

@DanAlbert --- i don't know whether you want to revert the bionic change for r28 or cherrypick the llvm change? (llvm/llvm-project@7d20ea9)

[DanAlbert]

I currently can't make any changes to the sysroot, so it'll have to be the LLVM change.

[pirama-arumuga-nainar]

r.android.com/3579430 backports the fix to clang-r530567 (in r28).