-
Notifications
You must be signed in to change notification settings - Fork 765
Add support for RTSP Opus #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
be108b9
3a87039
f0d7d96
0bf1973
165e706
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,146 @@ | ||
| /* | ||
| * Copyright 2022 The Android Open Source Project | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package androidx.media3.exoplayer.rtsp.reader; | ||
|
|
||
| import static androidx.media3.common.util.Assertions.checkArgument; | ||
| import static androidx.media3.common.util.Assertions.checkStateNotNull; | ||
|
|
||
| import androidx.media3.common.C; | ||
| import androidx.media3.common.Format; | ||
| import androidx.media3.common.util.Log; | ||
| import androidx.media3.common.util.ParsableByteArray; | ||
| import androidx.media3.common.util.Util; | ||
| import androidx.media3.exoplayer.rtsp.RtpPacket; | ||
| import androidx.media3.exoplayer.rtsp.RtpPayloadFormat; | ||
| import androidx.media3.extractor.ExtractorOutput; | ||
| import androidx.media3.extractor.OpusUtil; | ||
| import androidx.media3.extractor.TrackOutput; | ||
| import java.util.List; | ||
| import org.checkerframework.checker.nullness.qual.MonotonicNonNull; | ||
|
|
||
| /** | ||
| * Parses an OPUS byte stream carried on RTP packets and extracts individual samples. Refer to | ||
| * RFC7845 for more details. | ||
| */ | ||
| /* package */ final class RtpOpusReader implements RtpPayloadReader { | ||
| private static final String TAG = "RtpOpusReader"; | ||
|
|
||
| private final RtpPayloadFormat payloadFormat; | ||
| private static final long MEDIA_CLOCK_FREQUENCY = 48_000; | ||
|
|
||
| private @MonotonicNonNull TrackOutput trackOutput; | ||
| private long firstReceivedTimestamp; | ||
| private long startTimeOffsetUs; | ||
| private int previousSequenceNumber; | ||
| private boolean foundOpusIDHeader; | ||
| private boolean foundOpusCommentHeader; | ||
|
|
||
| public RtpOpusReader(RtpPayloadFormat payloadFormat) { | ||
| this.payloadFormat = payloadFormat; | ||
| this.firstReceivedTimestamp = C.INDEX_UNSET; | ||
| this.previousSequenceNumber = C.INDEX_UNSET; | ||
| this.foundOpusIDHeader = false; | ||
| this.foundOpusCommentHeader = false; | ||
| } | ||
|
|
||
| // RtpPayloadReader implementation. | ||
|
|
||
| @Override | ||
| public void createTracks(ExtractorOutput extractorOutput, int trackId) { | ||
| trackOutput = extractorOutput.track(trackId, C.TRACK_TYPE_AUDIO); | ||
| trackOutput.format(payloadFormat.format); | ||
| } | ||
|
|
||
| @Override | ||
| public void onReceivingFirstPacket(long timestamp, int sequenceNumber) { | ||
| this.firstReceivedTimestamp = timestamp; | ||
| } | ||
|
|
||
| @Override | ||
| public void consume( | ||
| ParsableByteArray data, long timestamp, int sequenceNumber, boolean rtpMarker) { | ||
| checkStateNotNull(trackOutput); | ||
|
|
||
| /* RFC7845 Section 3. | ||
| * +---------+ +----------------+ +--------------------+ +----- | ||
| * |ID Header| | Comment Header | |Audio Data Packet 1 | | ... | ||
| * +---------+ +----------------+ +--------------------+ +----- | ||
| */ | ||
| if (!foundOpusIDHeader) { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sorry for not getting back to this sooner, I thought we have merged it. All the logic here to find Opus ID and comment headers imply that the header and comment header is ONE PACKET long. But that is not what is specified in the RFC. According to the RFC, the ID header is one PAGE long, and the comment header can span across many pages. And one page can span multiple RTP packets. Also, "Audio data packets might span page boundaries. The first audio data page could have the 'continued packet' flag set" Although this is working right now, it's not semantically correct. So please try to make it compliant with the RFC by supporting multiple packet pages. There are examples of one access unit spans multiple RTP packets, like in the H264/265 reader. It's probably hard to test, but given you have some tests going on, please add some test based on your interpretation to the RFC.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sorry for not getting back to this sooner, I thought we have merged it. All the logic here to find Opus ID and comment headers imply that the header and comment header is ONE PACKET long. But that is not what is specified in the RFC. According to the RFC, the ID header is one PAGE long, and the comment header can span across many pages. And one page can span multiple RTP packets. Also, "Audio data packets might span page boundaries. The first audio data page could have the 'continued packet' flag set" Although this is working right now, it's not semantically correct. So please try to make it compliant with the RFC by supporting multiple packet pages. There are examples of one access unit spans multiple RTP packets, like in the H264/265 reader. It's probably hard to test, but given you have some tests going on, please add some test based on your interpretation to the RFC. |
||
| checkForOpusIdHeader(data); | ||
| List<byte[]> initializationData = OpusUtil.buildInitializationData(data.getData()); | ||
| Format.Builder formatBuilder = payloadFormat.format.buildUpon(); | ||
| formatBuilder.setInitializationData(initializationData); | ||
| trackOutput.format(formatBuilder.build()); | ||
| foundOpusIDHeader = true; | ||
| } else if (!foundOpusCommentHeader) { | ||
claincly marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| // Comment Header RFC7845 Section 5.2. | ||
| int sampleSize = data.limit(); | ||
| checkArgument(sampleSize >= 8 , "Comment Header has insufficient data"); | ||
| String header = data.readString(8); | ||
| checkArgument(header.equals("OpusTags"), "Comment Header should follow ID Header"); | ||
| foundOpusCommentHeader = true; | ||
| } else { | ||
| // Check that this packet is in the sequence of the previous packet. | ||
| int expectedSequenceNumber = RtpPacket.getNextSequenceNumber(previousSequenceNumber); | ||
| if (sequenceNumber != expectedSequenceNumber) { | ||
| Log.w( | ||
| TAG, | ||
| Util.formatInvariant( | ||
| "Received RTP packet with unexpected sequence number. Expected: %d; received: %d.", | ||
| expectedSequenceNumber, sequenceNumber)); | ||
| } | ||
|
|
||
| // sending opus data. | ||
| int size = data.bytesLeft(); | ||
| trackOutput.sampleData(data, size); | ||
| long timeUs = | ||
| toSampleTimeUs(startTimeOffsetUs, timestamp, firstReceivedTimestamp); | ||
| trackOutput.sampleMetadata( | ||
| timeUs, C.BUFFER_FLAG_KEY_FRAME, size, /* offset*/ 0, /* cryptoData*/ null); | ||
| } | ||
| previousSequenceNumber = sequenceNumber; | ||
| } | ||
|
|
||
| @Override | ||
| public void seek(long nextRtpTimestamp, long timeUs) { | ||
| firstReceivedTimestamp = nextRtpTimestamp; | ||
| startTimeOffsetUs = timeUs; | ||
| } | ||
|
|
||
| // Internal methods. | ||
|
|
||
| private static void checkForOpusIdHeader(ParsableByteArray data) { | ||
| int currPosition = data.getPosition(); | ||
| int sampleSize = data.limit(); | ||
| checkArgument(sampleSize > 18, "ID Header has insufficient data"); | ||
| String header = data.readString(8); | ||
| // Identification header RFC7845 Section 5.1. | ||
| checkArgument(header.equals("OpusHead"), "ID Header missing"); | ||
| checkArgument(data.readUnsignedByte() == 1, "version number must always be 1"); | ||
| data.setPosition(currPosition); | ||
| } | ||
|
|
||
| /** Returns the correct sample time from RTP timestamp, accounting for the OPUS sampling rate. */ | ||
| private static long toSampleTimeUs( | ||
| long startTimeOffsetUs, long rtpTimestamp, long firstReceivedRtpTimestamp) { | ||
| return startTimeOffsetUs | ||
| + Util.scaleLargeTimestamp( | ||
| rtpTimestamp - firstReceivedRtpTimestamp, | ||
| /* multiplier= */ C.MICROS_PER_SECOND, | ||
| /* divisor= */ MEDIA_CLOCK_FREQUENCY); | ||
| } | ||
| } | ||
Uh oh!
There was an error while loading. Please reload this page.