Fix NPE in MediaControllerImplLegacy#connectToSession()#59
Merged
icbaker merged 2 commits intoandroidx:mainfrom Apr 26, 2022
Merged
Conversation
Current implementation of the release() method have a bug; it does not clear pending messages/callbacks queued to the applicationHandler.
This fixes the NPE ocuured in the MediaControllerImplLegacy#connectToSession() right after MediaController#release() is called.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes a
NullPointerExceptionoccurs inside of theMediaControllerImplLegacy#connectToSession().Where the
NPEoccursmedia/libraries/session/src/main/java/androidx/media3/session/MediaControllerImplLegacy.java
Line 1274 in 72a4fb0
Scenario
MediaControllerinstanceMediaControllerImplLegacyposts a callback which is executed on the main threadMediaController#release()immediately on the main threadMediaControllerImplLegacysetscontrollerCompat = nullcontrollerCompat.isSessionReady()is called 💥