Fix AudioCapabilities regression#728
Merged
copybara-service[bot] merged 2 commits intoandroidx:mainfrom Oct 19, 2023
Merged
Conversation
Since DEFAULT_MAX_CHANNEL_COUNT was increased from 8 to 10, getMaxSupportedChannelCountForPassthrough always throws if its loop enters its second iteration (channelCount of 9). This is due to Util.getAudioTrackChannelConfig returning CHANNEL_INVALID when passed a channelCount of 9, and setting CHANNEL_INVALID as the AudioFormat's channel mask throws an exception. This change skips each iteration where CHANNEL_INVALID is returned.
tonihei
force-pushed
the
audio-capabilities-fix
branch
from
8117b82 to
8f44916
Compare
rohitjoins
pushed a commit
that referenced
this pull request
Oct 23, 2023
PiperOrigin-RevId: 574829263 (cherry picked from commit 5f80a47)
rohitjoins
pushed a commit
that referenced
this pull request
Oct 24, 2023
PiperOrigin-RevId: 574829263 (cherry picked from commit 5f80a47)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since DEFAULT_MAX_CHANNEL_COUNT was increased from 8 to 10, getMaxSupportedChannelCountForPassthrough always throws if its loop enters its second iteration (channelCount of 9). This is due to Util.getAudioTrackChannelConfig returning CHANNEL_INVALID when passed a channelCount of 9, and setting CHANNEL_INVALID as the AudioFormat's channel mask throws an exception.
This change skips each iteration where CHANNEL_INVALID is returned.
Fixes issue #677