Ignore rowLock and columnLock values as specified by ANSI/CTA-708-E S…#942
Merged
copybara-service[bot] merged 5 commits intoandroidx:mainfrom Jan 9, 2024
Merged
Conversation
icbaker
reviewed
Jan 3, 2024
Collaborator
icbaker
left a comment
icbaker
left a comment
There was a problem hiding this comment.
Thanks for the PR - can you please add a test case to Cea708ParserTest to demonstrate that even if row/column locking is disabled the rows are still assumed to be locked?
libraries/extractor/src/main/java/androidx/media3/extractor/text/cea/Cea708Parser.java
Outdated
Show resolved
Hide resolved
Collaborator
|
I'm going to send this for internal review now. You may see some more commits being added as I make changes in response to review feedback. Please refrain from pushing any more substantive changes as it will complicate the internal review - thanks! |
…-2023 document (section 8.4.7)
Add singleServiceAndWindowDefinition_ignoreRowLock test to Cea708ParserTest
icbaker
force-pushed
the
CC_708_parser_fix
branch
from
dd739c3 to
4a4dcdb
Compare
Also add a release note and simplify the test by removing the garbage prefix and suffix.
icbaker
force-pushed
the
CC_708_parser_fix
branch
from
4a4dcdb to
0b482ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ANSI CTA-708-E S-2023 specification indicates that row and column lock values should be ignored in DefineWindow command and decoders should assume rows and columns are locked.
8.4.7 Window Row and Column Locking
Prior to CEA-708-D, parameters row lock (rl) and column lock (cl) in the DefineWindow (DFx) command were used for control of window row and column locking, providing alternatives in growing and shrinking caption windows. This standard specifies a single method for window growing and shrinking, and in Section 8.10.5.2 these parameters are reserved. Future versions of this standard may allow use of these parameters, but decoders compliant with the present version of CEA-708 shall ignore the values, and assume rows and columns are locked. Future versions of this standard may allow the optional decoder implementation of windows with unlocked rows and columns, and may use these syntax elements.
The change is to make Cea708Parser follow the specification.