Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.
This repository was archived by the owner on May 29, 2019. It is now read-only.

tab type is not set correctly if used as in the documentation #1514

Description

@bsr203

Hello,

I have issue rendering tab directive correctly in my local setup. When I use the same versions in plnkr, it works fine. I narrowed down the issue to below line.
https://github.com/angular-ui/bootstrap/blob/master/src/tabs/tabs.js#L83
scope.type = angular.isDefined(attrs.type) ? scope.$parent.$eval(attrs.type) : 'tabs';

I am not sure where is it changed, but $eval returns undefined if I use it like

tabset(type="pills")

but it works fine if

tabset(type="'pills'")

it makes sense as scope.$parent.$eval(attrs.type) undefined as there is no variable pills (returned by attrs.type) in the scope. But I am not sure how it works on plnkr (example in the doc) though .

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions