[dialog] Resolves shouldn't be part of global options

[pkozlowski-opensource]

Was playing with $dialog today and while it is awesome I think that we could do it better. I'm kind of uneasy with the fact that resolve can be only passed as a global variable and not as part of the open(). IMO it makes sense that if we can specify a controller and a template we can also specify resolves.

In fact I was trying to answer this question: http://stackoverflow.com/q/15048392/1418796 and realized that using $dialog is more complex that it needs to be.

WDYT?

[SidhNor]

Totally agree.
Do you think we should add just the resolve param or the whole options?
The option thingy can cause trouble though.

[pkozlowski-opensource]

@SidhNor IMO we should remove resolve from the global options and pass it to the open method.

In my mind $dialog.dialog should be a factory of a pre-configured modal (with visual options set) and then I can call open with different set of data.

But since I didn't write the original version maybe I'm missing sth...

[typesafe]

@pkozlowski-opensource, I agree that passing resolves to open makes the most sense. It is currently in the global options because it's inspired by routing (Andy).

A current workaround could be recreating the dialog instance with new options containing (only) the resolve object which will overwrite existing resolves, if any. This is very lightweight to do BTW since there's no DOM manipulation until you actually open the dialog.

[pkozlowski-opensource]

Will be fixed in #441