feat(@schematics/angular): add lintFix to several other schematics#12938
Merged
Conversation
alan-agius4
added
the
target: major
filipesilva
requested review from
clydin and
hansl
and removed request for
filipesilva
November 12, 2018 19:43
Contributor
alan-agius4
added
needs: discussion
clydin
approved these changes
Dec 13, 2018
clydin
left a comment
clydin
left a comment
Member
There was a problem hiding this comment.
This should probably be done at the cli level at some point so it doesn’t have to be inserted into every schematic. Especially since the actual linter is configurable at the cli level. Third party schematics also aren’t affected by this either.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment some schematics contain this options for instance the
guard,componentetc.. But some others don't such asmoduleFixes #12894 and Fixes #6272