fix(@angular/cli): change strategy for opening the browser when we ca… - #13615
Merged
Conversation
alan-agius4
reviewed
Feb 7, 2019
Collaborator
|
@wKoza, just a side note, we should not add an addition open for the browser to open. We should always rely on the default browser. As we'd like to limit the options, and avoid adding unnecessary once. |
Contributor
Author
|
@alan-agius4 , I understand concerning the option property. I hadn't default browser (It's not my PC ...); But now It's ok; I no longer need of the |
alan-agius4
added
target: patch
Collaborator
|
@wKoza small nit, would you mind fixing the commit msg? As the description is not correct. Thanks |
…dy resolve is already resolve.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ll
ng docwith Windows.Closes #13575