Skip to content

refactor(@angular-devkit/build-angular): remove usage of rimraf package - #21049

Merged
alan-agius4 merged 1 commit into
angular:masterfrom
alan-agius4:rimraf-build-angular
Jun 4, 2021
Merged

refactor(@angular-devkit/build-angular): remove usage of rimraf package#21049
alan-agius4 merged 1 commit into
angular:masterfrom
alan-agius4:rimraf-build-angular

Conversation

@alan-agius4

Copy link
Copy Markdown
Collaborator

Use Node.JS rmdirSync instead.

@alan-agius4
alan-agius4 requested a review from clydin June 4, 2021 12:01
@google-cla google-cla Bot added the cla: yes label Jun 4, 2021
@alan-agius4 alan-agius4 added target: minor This PR is targeted for the next minor release and removed cla: yes labels Jun 4, 2021
@google-cla google-cla Bot added the cla: yes label Jun 4, 2021
@angular angular deleted a comment from google-cla Bot Jun 4, 2021

@clydin clydin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be able to remove the package from the root package.json as well now.

@alan-agius4

Copy link
Copy Markdown
Collaborator Author

It’s being used by a number of e2e tests

@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Jun 4, 2021
@alan-agius4
alan-agius4 merged commit c0106f6 into angular:master Jun 4, 2021
@alan-agius4
alan-agius4 deleted the rimraf-build-angular branch June 4, 2021 13:37
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Jul 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants