Skip to content

fix(@angular-devkit/build-angular): transform remapped sourcemap into a plain object#21978

Merged
clydin merged 1 commit into
angular:12.2.xfrom
alan-agius4:patch-sm-code-coverage
Oct 19, 2021
Merged

fix(@angular-devkit/build-angular): transform remapped sourcemap into a plain object#21978
clydin merged 1 commit into
angular:12.2.xfrom
alan-agius4:patch-sm-code-coverage

Conversation

@alan-agius4

Copy link
Copy Markdown
Collaborator

Patch version of #21977

… a plain object

`remapping` will return a SourceMap which it's prototype is not a simple object. This causes Babel to fail when it invoked from `istanbul-lib-instrument` because Babel with `don't know how to turn this value into a node` error as Babel will not process not simple objects.

See: https://github.com/babel/babel/blob/780aa48d2a34dc55f556843074b6aed45e7eabeb/packages/babel-types/src/converters/valueToNode.ts#L115-L130

Closes #21967

(cherry picked from commit da1733c)
@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Oct 19, 2021
@alan-agius4
alan-agius4 requested a review from clydin October 19, 2021 13:42
@google-cla google-cla Bot added the cla: yes label Oct 19, 2021
@clydin clydin added the action: merge The PR is ready for merge by the caretaker label Oct 19, 2021
@clydin
clydin merged commit 6173609 into angular:12.2.x Oct 19, 2021
@alan-agius4
alan-agius4 deleted the patch-sm-code-coverage branch October 19, 2021 15:57
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Nov 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants