Skip to content

feat(@schematics/angular): add VS Code configurations when generating a new workspace - #22167

Merged
alan-agius4 merged 1 commit into
angular:masterfrom
alan-agius4:vscode-config
Nov 18, 2021
Merged

feat(@schematics/angular): add VS Code configurations when generating a new workspace#22167
alan-agius4 merged 1 commit into
angular:masterfrom
alan-agius4:vscode-config

Conversation

@alan-agius4

Copy link
Copy Markdown
Collaborator

When generating a new workspace we now generate several VS Code configurations.

  • extensions: we added config to recommand to use official VS Code extensions.
  • launch: added run and debug launch scripts for ng test and ng serve
  • tasks: configured npm start and npm test to better support the launch scripts

More information about each files can be found

Closes #2672

@alan-agius4 alan-agius4 added the target: minor This PR is targeted for the next minor release label Nov 15, 2021
@google-cla google-cla Bot added the cla: yes label Nov 15, 2021
… a new workspace

When generating a new workspace we now generate several VS Code configurations.

- extensions: we added config to recommand to use official VS Code extensions.
- launch: added run and debug launch scripts for `ng test` and `ng serve`
- tasks: configured `npm start` and `npm test` to better support the launch scripts

More information about each files can be found
- extensions: https://go.microsoft.com/fwlink/?linkid=827846
- launch: https://go.microsoft.com/fwlink/?linkid=830387
- tasks: https://go.microsoft.com/fwlink/?LinkId=733558

Closes #2672

@dgp1130 dgp1130 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I assume we don't want to migrate existing projects since they may already have their own configuration and may not want such a configuration if they don't use VSCode.

Should we consider an optional migration for those than want to update or "canonicalize" their debugging configuration in existing projects?

@alan-agius4

Copy link
Copy Markdown
Collaborator Author

Should we consider an optional migration for those than want to update or "canonicalize" their debugging configuration in existing projects?

I don’t feel too strongly about this, but we can surly do an optional migration if we think it will be useful.

@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Nov 17, 2021
@alan-agius4
alan-agius4 merged commit d5d9f04 into angular:master Nov 18, 2021
@alan-agius4
alan-agius4 deleted the vscode-config branch November 18, 2021 05:44
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Dec 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Recommended VS Code configuration

3 participants