Skip to content

feat(@angular-devkit/build-angular): set dir attribute when using localization - #22210

Merged
alan-agius4 merged 1 commit into
angular:masterfrom
alan-agius4:i18n-dir
Nov 23, 2021
Merged

feat(@angular-devkit/build-angular): set dir attribute when using localization#22210
alan-agius4 merged 1 commit into
angular:masterfrom
alan-agius4:i18n-dir

Conversation

@alan-agius4

@alan-agius4 alan-agius4 commented Nov 22, 2021

Copy link
Copy Markdown
Collaborator

We add the dir (direction) HTML attribute when using localization.

Closes #16047

@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: minor This PR is targeted for the next minor release labels Nov 22, 2021
@alan-agius4
alan-agius4 requested a review from clydin November 22, 2021 07:52
@google-cla google-cla Bot added the cla: yes label Nov 22, 2021
Comment thread packages/angular_devkit/build_angular/src/utils/index-file/augment-index-html.ts Outdated
…ocalization

We add the `dir` (direction) HTML attribute when using localization.

Closes #16047
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 23, 2021
@alan-agius4
alan-agius4 merged commit 3c681b6 into angular:master Nov 23, 2021
@alan-agius4
alan-agius4 deleted the i18n-dir branch November 23, 2021 07:31
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Dec 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

i18n-locale should inject dir attribute

2 participants