fix(@angular-devkit/build-angular): ensure $localize calls are replaced in watch mode - #22461
Merged
Conversation
alan-agius4
added
the
target: patch
alan-agius4
requested review from
clydin and
dgp1130
and removed request for
clydin
January 10, 2022 14:37
dgp1130
approved these changes
Jan 10, 2022
…aced in watch mode When `translations` is undefined `$localize` calls are not replaced. https://github.com/angular/angular-cli/blob/2c9a33dddb38694b6940ec6981c49904de1ab636/packages/angular_devkit/build_angular/src/builders/dev-server/index.ts#L382 Closes #22435
Collaborator
|
This has a merge conflict with |
dgp1130
added
target: minor
Collaborator
|
Cherry picked to the patch branch in 6a617ff. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
translationsis undefined$localizecalls are not replaced.angular-cli/packages/angular_devkit/build_angular/src/builders/dev-server/index.ts
Line 382 in 2c9a33d
Closes #22435