test: use random ports for local verdaccio npm servers - #23114
Merged
Conversation
jbedard
force-pushed
the
random-npm-port
branch
4 times, most recently
from
May 10, 2022 19:43
7e25895 to
c02fdca
Compare
jbedard
marked this pull request as ready for review
May 10, 2022 20:05
jbedard
requested review from
alan-agius4 and
clydin
and removed request for
clydin
May 10, 2022 20:39
alan-agius4
reviewed
May 11, 2022
Comment on lines
+19
to
+20
| configContent = configContent.replace(/\$\{HTTP_PORT\}/g, String(port)); | ||
| configContent = configContent.replace(/\$\{HTTPS_PORT\}/g, String(httpsPort)); |
Collaborator
There was a problem hiding this comment.
NIT
Suggested change
| configContent = configContent.replace(/\$\{HTTP_PORT\}/g, String(port)); | |
| configContent = configContent.replace(/\$\{HTTPS_PORT\}/g, String(httpsPort)); | |
| configContent = configContent | |
| .replace(/\$\{HTTP_PORT\}/g, String(port)) | |
| .replace(/\$\{HTTPS_PORT\}/g, String(httpsPort)); |
Contributor
Author
There was a problem hiding this comment.
👍 but looks like it's too late...
Collaborator
There was a problem hiding this comment.
Ah sorry, didn't notice there was a change still pending. Not sure if you care enough to justify another PR for this cleanup @alan-agius4?
Collaborator
There was a problem hiding this comment.
@jbedard, feel free to include this suggested change in on of your upcoming PRs.
alan-agius4
added
target: rc
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Best viewed ignoring whitespace.
When working on the bazel e2e tests (#23074) we might run tests in parallel such as bazel + non-bazel, npm + yarn etc.
Unfortunately the verdaccio
--listenonly sets the primary port and not the fallback which we need to also set, so we need to do the.replacething :(