ci: use current minimum Node.js v16 version to test snapshot builds - #23143
Merged
Conversation
clydin
force-pushed
the
ci/fix-snapshots-e2e
branch
4 times, most recently
from
May 16, 2022 23:10
0eb694d to
efda44e
Compare
clydin
changed the title
clydin
force-pushed
the
ci/fix-snapshots-e2e
branch
3 times, most recently
from
May 17, 2022 14:33
5b4226c to
dfff175
Compare
clydin
marked this pull request as ready for review
May 17, 2022 16:03
Node.js 16.10 is currently the minimum version of v16 supported by the Angular CLI and is now used when executing the Angular snapshot E2E test suite to ensure that the latest snapshots of Angular continue to function at this Node.js version. Node.js v16 is the version currently used to develop the Angular CLI. The npm 7+ workaround of installing npm 6 is also removed to more closely track the behavior of Node.js 16.10 as well as any other Node.js version used during testing.
…nitial version The `misc/npm-7` E2E test previously assumed the initial version of npm was 6.x and would then always install 6.x after the test was complete. With newer Node.js versions this assumption is no longer true. The test now records the initial version present prior to starting the test and restores that recorded version at completion.
clydin
force-pushed
the
ci/fix-snapshots-e2e
branch
from
May 17, 2022 16:06
97adcfe to
d379886
Compare
clydin
added
the
action: review
alan-agius4
reviewed
May 18, 2022
| const { stdout: stdoutPack } = await silentNpm( | ||
| 'pack', | ||
| npmSpecifier, | ||
| '--registry=https://registry.npmjs.org', |
Collaborator
There was a problem hiding this comment.
--registry shouldn't be needed here.
Suggested change
| '--registry=https://registry.npmjs.org', |
clydin
added
action: merge
Contributor
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node.js 16.10 is currently the minimum version of v16 supported by the Angular CLI
and is now used when executing the Angular snapshot E2E test suite to ensure
that the latest snapshots of Angular continue to function at this Node.js version.
Node.js v16 is the version currently used to develop the Angular CLI.
The npm 7+ workaround of installing npm 6 is also removed to more closely track
the behavior of Node.js 16.10 as well as any other Node.js version used during
testing.