Skip to content

test: reduce use of npmrc for test npm configuration - #23299

Merged
clydin merged 1 commit into
angular:mainfrom
jbedard:e2e-auth
Jun 9, 2022
Merged

test: reduce use of npmrc for test npm configuration#23299
clydin merged 1 commit into
angular:mainfrom
jbedard:e2e-auth

Conversation

@jbedard

@jbedard jbedard commented Jun 7, 2022

Copy link
Copy Markdown
Contributor

This way npmrc can be used for global cross-test configuration and environment variables can be overridden locally for each test case. There's probably more but these are some simple ones for now.

@jbedard
jbedard force-pushed the e2e-auth branch 6 times, most recently from 0740d84 to b5609c1 Compare June 9, 2022 00:12
@jbedard
jbedard marked this pull request as ready for review June 9, 2022 01:27
@jbedard
jbedard requested review from alan-agius4 and clydin and removed request for clydin June 9, 2022 01:27
@clydin
clydin removed the request for review from alan-agius4 June 9, 2022 16:16
@clydin clydin added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release labels Jun 9, 2022
@clydin
clydin merged commit 7ce88c7 into angular:main Jun 9, 2022
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Jul 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants