Skip to content

test: ensure legacy peer dependency mode for E2E snapshot tests - #23311

Merged
clydin merged 1 commit into
angular:mainfrom
clydin:e2e/fix-snapshot-legacy-peers
Jun 7, 2022
Merged

test: ensure legacy peer dependency mode for E2E snapshot tests#23311
clydin merged 1 commit into
angular:mainfrom
clydin:e2e/fix-snapshot-legacy-peers

Conversation

@clydin

@clydin clydin commented Jun 7, 2022

Copy link
Copy Markdown
Member

Snapshot builds may contain versions that are not yet released (e.g., RC phase main branch).
In this case peer dependency ranges may not resolve causing npm 7+ to fail during tests.
To support this case, legacy peer dependency mode is enabled for snapshot builds.

@clydin clydin changed the title E2e/fix snapshot legacy peers test: ensure legacy peer dependency mode for E2E snapshot tests Jun 7, 2022
@clydin clydin added the target: minor This PR is targeted for the next minor release label Jun 7, 2022
@clydin
clydin force-pushed the e2e/fix-snapshot-legacy-peers branch from 0bfb209 to 1719646 Compare June 7, 2022 18:28
@clydin
clydin marked this pull request as ready for review June 7, 2022 18:29
@clydin
clydin requested a review from alan-agius4 June 7, 2022 18:29
@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jun 7, 2022
Comment thread tests/legacy-cli/e2e/setup/002-npm-sandbox.ts
Snapshot builds may contain versions that are not yet released (e.g., RC phase main branch).
In this case peer dependency ranges may not resolve causing npm 7+ to fail during tests.
To support this case, legacy peer dependency mode is enabled for snapshot builds.
@clydin
clydin force-pushed the e2e/fix-snapshot-legacy-peers branch from 1719646 to bd74370 Compare June 7, 2022 19:19
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jun 7, 2022
@clydin
clydin merged commit ffa9a06 into angular:main Jun 7, 2022
@clydin
clydin deleted the e2e/fix-snapshot-legacy-peers branch June 7, 2022 20:33
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Jul 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants