use private yarn pkg cache, ensure private npm/yarn bin always on path by jbedard · Pull Request #23372 · angular/angular-cli

jbedard · 2022-06-14T23:23:57Z

No description provided.

alan-agius4 · 2022-06-16T11:50:57Z

 * Configure npm to use a unique sandboxed environment.
 */
 export default async function () {
  const tempRoot: string = getGlobalVariable('tmp-root');


Shouldn't the configured based on the package manager is used?

The packages being tested (cli + yarn + npm) are all installed using npm before running the tests so I think we always need both (see 100-global-cli.ts).

jbedard · 2022-06-16T18:05:14Z

    console.log(`  ${envName}: ${process.env[envName]!.replace(/[\n\r]+/g, '\n        ')}`);
  });

+  await exec('which', 'ng', 'yarn', 'npm');


I added a commit adding this line to ensure the correct ng/yarn/npm are being used. You can omit that commit if you don't think it's useful.

jbedard · 2022-06-17T16:38:24Z

Currently the esbuild tests are failing when the main project npm install occurs, but only on the npm+esbuild test and not the normal npm test.

    - Installing packages (npm)...
    npm WARN old lockfile 
    npm WARN old lockfile The package-lock.json file was created with an old version of npm,
    npm WARN old lockfile so supplemental metadata must be fetched from the registry.
    npm WARN old lockfile 
    npm WARN old lockfile This is a one-time fix-up, please be patient...

then what seems like every package outputs:

    npm WARN old lockfile Error: ENOENT: no such file or directory, open '/mnt/ramdisk/e2e-esbuild/e2e-test/test-project/node_modules/abab/package.json'

Any ideas? Why would esbuild change anything regarding the npm install?

EDIT: this seems to be after cac7b14

jbedard · 2022-06-25T00:15:33Z

FWIW that esbuild job randomly switches between the error I listed above and:

  The esbuild browser application builder ('browser-esbuild') is currently experimental.
  The 'budgets' option is currently unsupported by this experimental builder and will be ignored.
  The 'extractLicenses' option is currently unsupported by this experimental builder and will be ignored.
  The 'fileReplacements' option is currently unsupported by this experimental builder and will be ignored.
  ✘ [ERROR] [plugin angular-compiler] Cannot resolve type entity i1.CommonModule to symbol
    This error came from the "onStart" callback registered here:
      node_modules/@angular-devkit/build-angular/src/builders/browser-esbuild/compiler-plugin.js:165:18:
        165 │             build.onStart(async () => {
            ╵                   ~~~~~~~
      at setup (/mnt/ramdisk/e2e-esbuild/e2e-test/test-project/node_modules/@angular-devkit/build-angular/src/builders/browser-esbuild/compiler-plugin.js:165:19)
      at async handlePlugins (/mnt/ramdisk/e2e-esbuild/e2e-test/test-project/node_modules/esbuild/lib/main.js:893:11)
  ✘ [ERROR] [plugin angular-compiler] Invalid plugin execution order
      node_modules/@angular-devkit/build-angular/src/builders/browser-esbuild/compiler-plugin.js:236:23:
        236 │                 assert.ok(fileEmitter, 'Invalid plugin execution ...
            ╵                        ^
      at /mnt/ramdisk/e2e-esbuild/e2e-test/test-project/node_modules/@angular-devkit/build-angular/src/builders/browser-esbuild/compiler-plugin.js:236:24
      at callback (/mnt/ramdisk/e2e-esbuild/e2e-test/test-project/node_modules/esbuild/lib/main.js:989:34)
      at handleRequest (/mnt/ramdisk/e2e-esbuild/e2e-test/test-project/node_modules/esbuild/lib/main.js:717:36)
      at handleIncomingPacket (/mnt/ramdisk/e2e-esbuild/e2e-test/test-project/node_modules/esbuild/lib/main.js:764:7)
      at Socket.readFromStdout (/mnt/ramdisk/e2e-esbuild/e2e-test/test-project/node_modules/esbuild/lib/main.js:640:7)
      at Socket.emit (events.js:315:20)
      at addChunk (internal/streams/readable.js:309:12)
      at readableAddChunk (internal/streams/readable.js:284:9)
      at Socket.Readable.push (internal/streams/readable.js:223:10)
      at Pipe.onStreamRead (internal/stream_base_commons.js:188:23)
    This error came from the "onLoad" callback registered here:
      node_modules/@angular-devkit/build-angular/src/builders/browser-esbuild/compiler-plugin.js:234:18:
        234 │             build.onLoad({ filter: compilerOptions.allowJs ? /\.[...
            ╵                   ~~~~~~
      at setup (/mnt/ramdisk/e2e-esbuild/e2e-test/test-project/node_modules/@angular-devkit/build-angular/src/builders/browser-esbuild/compiler-plugin.js:234:19)
      at async handlePlugins (/mnt/ramdisk/e2e-esbuild/e2e-test/test-project/node_modules/esbuild/lib/main.js:893:11)
  ✘ [ERROR] [plugin angular-compiler] Invalid plugin execution order
      node_modules/@angular-devkit/build-angular/src/builders/browser-esbuild/compiler-plugin.js:236:23:
        236 │                 assert.ok(fileEmitter, 'Invalid plugin execution ...
            ╵                        ^
      at /mnt/ramdisk/e2e-esbuild/e2e-test/test-project/node_modules/@angular-devkit/build-angular/src/builders/browser-esbuild/compiler-plugin.js:236:24
      at callback (/mnt/ramdisk/e2e-esbuild/e2e-test/test-project/node_modules/esbuild/lib/main.js:989:34)
      at handleRequest (/mnt/ramdisk/e2e-esbuild/e2e-test/test-project/node_modules/esbuild/lib/main.js:717:36)
      at handleIncomingPacket (/mnt/ramdisk/e2e-esbuild/e2e-test/test-project/node_modules/esbuild/lib/main.js:764:7)
      at Socket.readFromStdout (/mnt/ramdisk/e2e-esbuild/e2e-test/test-project/node_modules/esbuild/lib/main.js:640:7)
      at Socket.emit (events.js:315:20)
      at addChunk (internal/streams/readable.js:309:12)
      at readableAddChunk (internal/streams/readable.js:284:9)
      at Socket.Readable.push (internal/streams/readable.js:223:10)
      at Pipe.onStreamRead (internal/stream_base_commons.js:188:23)
    This error came from the "onLoad" callback registered here:
      node_modules/@angular-devkit/build-angular/src/builders/browser-esbuild/compiler-plugin.js:234:18:
        234 │             build.onLoad({ filter: compilerOptions.allowJs ? /\.[...
            ╵                   ~~~~~~
      at setup (/mnt/ramdisk/e2e-esbuild/e2e-test/test-project/node_modules/@angular-devkit/build-angular/src/builders/browser-esbuild/compiler-plugin.js:234:19)
      at async handlePlugins (/mnt/ramdisk/e2e-esbuild/e2e-test/test-project/node_modules/esbuild/lib/main.js:893:11)
      at ChildProcess.<anonymous> (/home/circleci/ng/tests/legacy-cli/e2e/utils/process.ts:112:20)
      at ChildProcess.emit (events.js:315:20)
      at Process.ChildProcess._handle.onexit (internal/child_process.js:277:12)

EDIT: this seems to be after cac7b14

jbedard · 2022-06-25T20:30:32Z

I'm going to drop cac7b14 for now so we can get the rest merged.

angular-automatic-lock-bot · 2022-08-07T08:03:07Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

jbedard force-pushed the yarn-private-cache branch from f0066e8 to 77060a1 Compare June 15, 2022 03:14

jbedard marked this pull request as ready for review June 15, 2022 03:39

jbedard requested a review from alan-agius4 June 15, 2022 03:39

jbedard mentioned this pull request Jun 15, 2022

run e2e legacy tests under bazel #23074

Merged

jbedard force-pushed the yarn-private-cache branch 2 times, most recently from 4498874 to 260710e Compare June 15, 2022 22:42

alan-agius4 reviewed Jun 16, 2022

View reviewed changes

Comment thread tests/legacy-cli/e2e/utils/process.ts Outdated

alan-agius4 reviewed Jun 16, 2022

View reviewed changes

Comment thread tests/legacy-cli/e2e/utils/process.ts Outdated

alan-agius4 reviewed Jun 16, 2022

View reviewed changes

Comment thread tests/legacy-cli/e2e/utils/process.ts Outdated

alan-agius4 added the target: minor This PR is targeted for the next minor release label Jun 16, 2022

jbedard force-pushed the yarn-private-cache branch 2 times, most recently from d07a4d6 to 6d8af93 Compare June 16, 2022 16:26

jbedard commented Jun 16, 2022

View reviewed changes

jbedard force-pushed the yarn-private-cache branch from 6d8af93 to 4787253 Compare June 16, 2022 18:06

jbedard commented Jun 16, 2022

View reviewed changes

Comment thread tests/legacy-cli/e2e/setup/002-npm-sandbox.ts Outdated

jbedard force-pushed the yarn-private-cache branch 2 times, most recently from 4805a3b to 9af75cd Compare June 16, 2022 20:21

jbedard force-pushed the yarn-private-cache branch 6 times, most recently from b2110d8 to 6278612 Compare June 24, 2022 23:18

jbedard force-pushed the yarn-private-cache branch from cac7b14 to 6278612 Compare June 25, 2022 20:30

jbedard requested a review from alan-agius4 June 25, 2022 20:30

jbedard force-pushed the yarn-private-cache branch from 6278612 to d5e94ba Compare July 7, 2022 06:07

jbedard requested a review from clydin July 7, 2022 06:15

jbedard added 4 commits July 7, 2022 13:48

test: ensure private npm is always on PATH

d761266

test: output env on child process error

8d22eb6

test: log the location of ng/npm/yarn being tested

7c8d1ce

test: align yarn and npm prefix config

6d7dc5b

alan-agius4 force-pushed the yarn-private-cache branch from d5e94ba to 6d7dc5b Compare July 7, 2022 13:48

alan-agius4 approved these changes Jul 7, 2022

View reviewed changes

clydin approved these changes Jul 7, 2022

View reviewed changes

alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Jul 7, 2022

alan-agius4 merged commit 01b4ad8 into angular:main Jul 7, 2022

angular-automatic-lock-bot Bot locked and limited conversation to collaborators Aug 7, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

use private yarn pkg cache, ensure private npm/yarn bin always on path - #23372

use private yarn pkg cache, ensure private npm/yarn bin always on path#23372
alan-agius4 merged 4 commits into
angular:mainfrom
jbedard:yarn-private-cache

jbedard commented Jun 14, 2022 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

alan-agius4 Jun 16, 2022

Uh oh!

jbedard Jun 16, 2022

Uh oh!

Uh oh!

jbedard Jun 16, 2022

Uh oh!

Uh oh!

jbedard commented Jun 17, 2022 •

edited

Loading

Uh oh!

jbedard commented Jun 25, 2022 •

edited

Loading

Uh oh!

jbedard commented Jun 25, 2022

Uh oh!

angular-automatic-lock-bot Bot commented Aug 7, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

jbedard commented Jun 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alan-agius4 Jun 16, 2022

Choose a reason for hiding this comment

Uh oh!

jbedard Jun 16, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jbedard Jun 16, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jbedard commented Jun 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jbedard commented Jun 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jbedard commented Jun 25, 2022

Uh oh!

angular-automatic-lock-bot Bot commented Aug 7, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jbedard commented Jun 14, 2022 •

edited

Loading

jbedard commented Jun 17, 2022 •

edited

Loading

jbedard commented Jun 25, 2022 •

edited

Loading