Skip to content

fix(@angular/cli): catch clause variable is not an Error instance #23645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alan-agius4 merged 2 commits into from
Jul 28, 2022
Merged

fix(@angular/cli): catch clause variable is not an Error instance #23645

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b277a1a
fix(@angular/cli): catch clause variable is not an Error instance
alan-agius4 Jul 27, 2022
0df359a
fix(@angular-devkit/build-angular): catch clause variable is not an E…
alan-agius4 Jul 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/angular/cli/src/utilities/error.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,9 @@
import assert from 'assert';

export function assertIsError(value: unknown): asserts value is Error & { code?: string } {
assert(value instanceof Error, 'catch clause variable is not an Error instance');
const isError =
value instanceof Error ||
// The following is needing to identify errors coming from RxJs.
(typeof value === 'object' && value && 'name' in value && 'message' in value);
assert(isError, 'catch clause variable is not an Error instance');
}
6 changes: 5 additions & 1 deletion packages/angular_devkit/build_angular/src/utils/error.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,9 @@
import assert from 'assert';

export function assertIsError(value: unknown): asserts value is Error & { code?: string } {
assert(value instanceof Error, 'catch clause variable is not an Error instance');
const isError =
value instanceof Error ||
// The following is needing to identify errors coming from RxJs.
(typeof value === 'object' && value && 'name' in value && 'message' in value);
assert(isError, 'catch clause variable is not an Error instance');
}