Skip to content

build: disable UT testing multiple node versions #23709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clydin merged 1 commit into from
Aug 9, 2022
Merged

build: disable UT testing multiple node versions #23709

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions tools/toolchain_info.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
# the order will match against the order in the TOOLCHAIN_VERSION list.
TOOLCHAINS_NAMES = [
"node14",
"node16",
# TODO enable one we know more why there is a memory usage increase and app-shell tests work with Node.js 16.
# "node16",
]

# this is the list of toolchains that should be used and are registered with nodejs_register_toolchains in the WORKSPACE file
Expand All @@ -14,11 +15,12 @@ TOOLCHAINS_VERSIONS = [
"@bazel_tools//src/conditions:darwin": "@node14_darwin_amd64//:node_toolchain",
"@bazel_tools//src/conditions:windows": "@node14_windows_amd64//:node_toolchain",
}),
select({
"@bazel_tools//src/conditions:linux_x86_64": "@node14_linux_amd64//:node_toolchain",
"@bazel_tools//src/conditions:darwin": "@node14_darwin_amd64//:node_toolchain",
"@bazel_tools//src/conditions:windows": "@node14_windows_amd64//:node_toolchain",
}),
# TODO enable one we know more why there is a memory usage increase and app-shell tests work with Node.js 16.
# select({
# "@bazel_tools//src/conditions:linux_x86_64": "@node16_linux_amd64//:node_toolchain",
# "@bazel_tools//src/conditions:darwin": "@node16_darwin_amd64//:node_toolchain",
# "@bazel_tools//src/conditions:windows": "@node16_windows_amd64//:node_toolchain",
# }),
]

# A default toolchain for use when only one is necessary
Expand Down