Skip to content

test: enable git core.longpaths option - #23926

Merged
clydin merged 1 commit into
angular:mainfrom
jbedard:e2e-git-longpath
Sep 19, 2022
Merged

test: enable git core.longpaths option#23926
clydin merged 1 commit into
angular:mainfrom
jbedard:e2e-git-longpath

Conversation

@jbedard

@jbedard jbedard commented Sep 17, 2022

Copy link
Copy Markdown
Contributor

If things like the temp dir, project root etc have long paths (such as custom paths passed on the cli, or bazel runfiles/temp directories) then this is required.

@alan-agius4 alan-agius4 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please remove

- run: git config --global core.longpaths true
?

@alan-agius4 alan-agius4 added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews target: patch This PR is targeted for the next patch release labels Sep 19, 2022
@jbedard

jbedard commented Sep 19, 2022

Copy link
Copy Markdown
Contributor Author

You don't think that might be necessary for other git actions? Or was it only for git being launched within the e2e tests?

@alan-agius4

Copy link
Copy Markdown
Collaborator

You don't think that might be necessary for other git actions? Or was it only for git being launched within the e2e tests?

It was the only one.

@jbedard

jbedard commented Sep 19, 2022

Copy link
Copy Markdown
Contributor Author

I guess as little as possible should be CI specific, updated 👍

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Sep 19, 2022
@clydin
clydin merged commit a4075c9 into angular:main Sep 19, 2022
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Oct 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants