build(@schematics/angular): use genrule for best practices copy - #33690
Merged
alan-agius4 merged 1 commit intoJul 30, 2026
Merged
Conversation
angular-robot
Bot
added
area: build & ci
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request replaces the copy_file rule with a genrule in packages/schematics/angular/BUILD.bazel to copy the Angular best practices template. The review feedback suggests using $(execpath) instead of $(location) in the genrule command for consistency and Bazel best practices, as well as simplifying the command to a single-line string.
alan-agius4
force-pushed
the
fix-schematics-best-practices-sandbox
branch
from
July 30, 2026 08:14
d27cc72 to
598d245
Compare
alan-agius4
added
target: patch
Replaces `copy_file` with `genrule` in `packages/schematics/angular/BUILD.bazel` to depend explicitly on `//:node_modules/@angular/core/dir`. When `@angular/core` is linked as a directory tree artifact, referencing an internal file label directly without depending on the directory artifact causes Bazel's sandbox not to stage `@angular/core` into the sandbox, failing with `cp: cannot stat 'node_modules/@angular/core/resources/best-practices.md'`.
alan-agius4
force-pushed
the
fix-schematics-best-practices-sandbox
branch
from
July 30, 2026 08:16
598d245 to
1637bb2
Compare
crisbeto
approved these changes
Jul 30, 2026
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check to confirm your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
packages/schematics/angular/BUILD.bazelusescopy_fileto copy//:node_modules/@angular/core/resources/best-practices.md. When@angular/coreis linked as a directory tree artifact (/dir), referencing an internal file label directly without depending on the directory artifact causes Bazel's sandbox not to stage@angular/coreinto the sandbox, failing withcp: cannot stat 'node_modules/@angular/core/resources/best-practices.md'.Issue Number: N/A
What is the new behavior?
Replaces
copy_filewithgenruleinpackages/schematics/angular/BUILD.bazelto depend explicitly on//:node_modules/@angular/core/dirinsrcs. This ensures Bazel stages the package directory into the sandbox forcopy_to_bin/npm_package_archivebuilds.Does this PR introduce a breaking change?
Other information