ci: upgrade to Sauce Connect 5 to fix SC4 deprecation - #33720
Conversation
angular-robot
Bot
added
the
area: build & ci
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes several bash scripts used for managing the Sauce Connect tunnel and updates the Protractor configuration file to set the Sauce Labs region to 'us' and include tunnel configurations for all browser capabilities. The feedback suggests refactoring the configuration to dynamically append the tunnel properties to the capabilities array, which reduces boilerplate and prevents potential session creation failures when the tunnel identifier is undefined.
a0cc10d to
ae1e20b
Compare
|
/gemini review |
alan-agius4
added
target: patch
There was a problem hiding this comment.
Code Review
This pull request removes the legacy Sauce Connect bash scripts and refactors the Protractor Sauce Labs configuration. It extracts the browser capabilities into a separate array, configures the Sauce Labs region, and dynamically maps capabilities to inject tunnel configuration when a tunnel identifier is present. The feedback recommends mapping legacy capability properties ('version' and 'platform') to their W3C equivalents ('browserVersion' and 'platformName') to ensure full compatibility with modern WebDriver clients.
There was a problem hiding this comment.
Code Review
This pull request removes legacy Sauce Connect bash scripts and refactors the Protractor Saucelabs configuration file to extract browser capabilities and dynamically configure tunnel options. Feedback suggests mapping legacy JWP properties (version and platform) to W3C WebDriver syntax (browserVersion and platformName) within the capabilities mapping to fully support W3C syntax as intended.
alan-agius4
added
target: minor
Starting July 31, 2026, Sauce Labs servers will no longer support Sauce Connect 4 traffic. This commit migrates the CI workflow to use saucelabs/sauce-connect-action@v3 (Sauce Connect 5) and refactors the Protractor Sauce Labs capabilities configuration.
7a38994 to
66fa7c5
Compare
alan-agius4
added
action: review
dgp1130
left a comment
dgp1130
left a comment
There was a problem hiding this comment.
Looks a lot cleaner, thanks for taking a look at this!
alan-agius4
added
action: merge
2 participants
This PR upgrades Sauce Connect from legacy SC4 scripts to the official
saucelabs/sauce-connect-action@v3(Sauce Connect 5) to resolve the Sauce Connect 4 traffic.Changes
start-tunnel.sh,wait-for-tunnel.sh,stop-tunnel.sh) with official GitHub Action in.github/workflows/ci.ymlprotractor-saucelabs.conf.jsto support W3C WebDriver syntax alongside legacy syntax.github/workflows/pr.ymlto test Sauce Connect 5 on PR CI. This step will be removed once verified green.