feat(@angular/cli): add ability to build bundle for node by FrozenPandaz · Pull Request #6913 · angular/angular-cli

FrozenPandaz · 2017-07-07T03:14:55Z

This adds the ability to create a commonjs bundle which contains the application module/ngfactory which can be used in node environments

Here's an example of how a project using this feature would look https://github.com/FrozenPandaz/u-cli-app

hansl

1 question for now

hansl · 2017-07-11T00:35:09Z


 @Injectable()
 export class MyInjectable {
-  constructor(public viewContainer: ViewContainerRef, @Inject(DOCUMENT) public doc) {}


VCR is not an ordinary injectable

It can only be injected from a component and it's value is the VCR of the specific instance of the component.

A service/ injectable is not able to inject a VCR

This is to test the downgrading of a non-annotated Angular class. I think the test needs to happen, I don't care much with which class. Does this test makes your code fail? How so?

This test is done in the normal webpack tests.

This test makes my tests fail because I am actually executing the application and it fails to bootstrap because the service is not able to find the VCR.

Is it fine to remove it from this set of tests because the functionality is covered in the other webpack tests?

hansl · 2017-07-11T16:25:31Z

    .then(() => expectFileToMatch('dist/app.main.js',
-      /renderModuleFactory \*\/\].*\/\* AppModuleNgFactory \*\/\]/))
+        /renderModuleFactory \*\/\].*\/\* AppModuleNgFactory \*\/\]/))
+    .then(() => exec(normalize('rm'),


Considering there's no path, normalize('rm') is a noop.

hansl · 2017-07-12T22:43:11Z

            "description": "Base url for the application being built."
          },
+          "platform": {
+            "type": "string",


This should be an enum, not a generic stsring.

This is done.

hansl · 2017-07-17T22:03:06Z

    if (project.root === path.resolve(outputPath)) {
      throw new SilentError ('Output path MUST not be project root directory!');
    }
+    if (appConfig.platform && appConfig.platform === 'server') {


appConfig.platform is redundant here.

hansl · 2017-07-17T22:03:34Z

            .then(() => _removeDecorators(refactor))
-            .then(() => _refactorBootstrap(plugin, refactor));
+            .then(() => _refactorBootstrap(plugin, refactor))
+            .then(() => _stuff(plugin, refactor))


_stuff? I'm sure you can do better ;)

alxhub · 2017-07-18T20:56:02Z

+      });
+
+      const dirName = path.normalize(path.dirname(refactor.fileName));
+      let exportStatement = `export const moduleMap = ${JSON.stringify(map)};`;


Change this to not use JSON.stringify and instead properly build up the export map without string replacement hacks.

Also, let's rename the exported symbol to LAZY_MODULE_FACTORY_MAP.

alxhub · 2017-07-18T21:06:12Z

+          return {
+            loadChildrenString: routeKey,
+            path: plugin.lazyRoutes[lazyRouteKey],
+            name: routeKey.split('#')[1]


Add validation that the loadChildren format is correct.

Jason has addressed the issues

alxhub · 2017-07-19T18:45:08Z

+          refactor.prependBefore(node, `import * as __lazy_${index}__ from './${relativePath}'`);
+          return `"${routeKey}": __lazy_${index}__.${moduleName}`;
+        })
+        .join();


Wait, how are these separated. Shouldn't it be joined with a comma or something?

Never mind, apparently comma is the default for join().

alxhub · 2017-07-19T18:48:19Z

+
+          const modulePath = plugin.lazyRoutes[lazyRouteKey];
+          const relativePath = path.relative(dirName, modulePath).replace(/\\/g, '/');
+          refactor.prependBefore(node, `import * as __lazy_${index}__ from './${relativePath}'`);


It's weird for .map to have side effects. Can we move this out to a separate .forEach iteration through the keys?

alxhub · 2017-07-19T20:21:08Z

+          refactor.prependBefore(node, `import * as __lazy_${index}__ from './${relativePath}'`);
+          return `"${routeKey}": __lazy_${index}__.${moduleName}`;
+        })
+        .join();


Never mind, apparently comma is the default for join().

…azy route map

hansl · 2017-07-20T22:01:20Z

Just confirmed locally that the e2e tests are flakes and everything is green. Cheers.

intellix · 2017-07-22T06:25:14Z

Was just playing with this and found an issue with a particular export pattern in barrels that is broken: intellix/universal-cli@8ed967d#diff-a44e09a3c12667be300e8cb75d793c5dR1

Worked inside @app/user/index.ts:

export * from './user.module';
export * from './user.service';

Didn't work inside app/user/index.ts:

export { UserModule } from './user.module';
export { UserService } from './user.service';

Build error:

Date: 2017-07-22T06:19:07.696Z
Hash: f089fcd9ebdfb15dd64e
Time: 2950ms
chunk {main} main.bundle.js (main) 20.8 kB [entry] [rendered]
chunk {polyfills} polyfills.bundle.js (polyfills) 6.35 kB [entry] [rendered]
chunk {styles} styles.bundle.js (styles) 13.7 kB [entry] [rendered]


ERROR in ./src/app/user/index.ts
Module parse failed: /Users/dominic/Sites/test/universal/node_modules/@ngtools/webpack/src/index.js!/Users/dominic/Sites/test/universal/src/app/user/index.ts Duplicate export 'LAZY_MODULE_MAP' (5:11)
You may need an appropriate loader to handle this file type.
| export var LAZY_MODULE_MAP = { "./lazy/lazy.module#LazyModule": __lazy_0__.LazyModule };
| export { UserService } from './user.service';
| export var LAZY_MODULE_MAP = { "./lazy/lazy.module#LazyModule": __lazy_0__.LazyModule };
| //# sourceMappingURL=index.js.map
@ ./src/app/app.module.ts 12:0-36
@ ./src/main.server.ts
@ multi ./src/main.server.ts

FrozenPandaz · 2017-07-23T23:34:13Z

@intellix Thank you for testing this feature and for the replication for the issue.

I have prepared a fix for this issue but would you do the honors of logging it as an issue in this GitHub repo?

Thank you

angular-automatic-lock-bot · 2019-09-12T02:42:32Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label Jul 7, 2017

FrozenPandaz force-pushed the serverbuild branch 3 times, most recently from 31c8e93 to 160ca2c Compare July 10, 2017 23:57

hansl previously requested changes Jul 11, 2017

View reviewed changes

FrozenPandaz force-pushed the serverbuild branch 5 times, most recently from df8d278 to 2602917 Compare July 11, 2017 04:11

hansl reviewed Jul 11, 2017

View reviewed changes

hansl reviewed Jul 12, 2017

View reviewed changes

FrozenPandaz force-pushed the serverbuild branch 2 times, most recently from eb675f2 to 04d605e Compare July 14, 2017 06:14

hansl reviewed Jul 17, 2017

View reviewed changes

FrozenPandaz force-pushed the serverbuild branch 4 times, most recently from d6e695d to ed7f5f0 Compare July 18, 2017 03:07

alxhub reviewed Jul 18, 2017

View reviewed changes

FrozenPandaz force-pushed the serverbuild branch 2 times, most recently from e127c52 to a2d4ddb Compare July 19, 2017 01:22

alxhub requested changes Jul 19, 2017

View reviewed changes

alxhub reviewed Jul 19, 2017

View reviewed changes

FrozenPandaz force-pushed the serverbuild branch 2 times, most recently from eafa684 to b6ae689 Compare July 20, 2017 18:53

alxhub previously approved these changes Jul 20, 2017

View reviewed changes

feat(@angular/cli): add ability to build bundle for node and export l…

f089a33

…azy route map

FrozenPandaz dismissed alxhub’s stale review via f089a33 July 20, 2017 19:12

FrozenPandaz force-pushed the serverbuild branch from b6ae689 to f089a33 Compare July 20, 2017 19:12

hansl merged commit 6f23636 into angular:master Jul 20, 2017

intellix mentioned this pull request Jul 21, 2017

feat(@angular/cli): add platform: server #5547

Closed

FrozenPandaz deleted the serverbuild branch July 23, 2017 18:13

intellix mentioned this pull request Jul 24, 2017

Duplicate LAZY_ROUTE_MAP exports with platform server in 1.3.0-rc.0 #7116

Closed

somombo mentioned this pull request Aug 17, 2017

Integrating angular2 Universal with angular CLI project #1050

Closed

angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 12, 2019

Uh oh!

Conversation

FrozenPandaz commented Jul 7, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hansl left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hansl commented Jul 20, 2017

Uh oh!

intellix commented Jul 22, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

FrozenPandaz commented Jul 23, 2017

Uh oh!

angular-automatic-lock-bot Bot commented Sep 12, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

FrozenPandaz commented Jul 7, 2017 •

edited

Loading

intellix commented Jul 22, 2017 •

edited

Loading