Skip to content

feat(@angular/cli): support TypeScript 2.4 - #7065

Merged
Brocco merged 1 commit into
angular:masterfrom
filipesilva:ts-2.4-pr
Jul 21, 2017
Merged

feat(@angular/cli): support TypeScript 2.4#7065
Brocco merged 1 commit into
angular:masterfrom
filipesilva:ts-2.4-pr

Conversation

@filipesilva

@filipesilva filipesilva commented Jul 20, 2017

Copy link
Copy Markdown
Contributor

This PR doesn't change new projects to use 2.4 since I have seen some reports of possible problems in @angular/*.

Instead, it:

  • removes the dependency restrictions on <2.3
  • bumps related dependencies (rxjs@^5.4.2, ts-node@~3.2.0) to the minimum that supports 2.4
  • builds the CLI itself using 2.4

So if you want to install ts 2.4 in your new project, the CLI itself won't stop you.

Fix #6827

@filipesilva
filipesilva requested a review from hansl as a code owner July 20, 2017 13:34
@filipesilva

Copy link
Copy Markdown
Contributor Author

Followup from #6891, had to close it because the CLA check bugged.

@filipesilva

Copy link
Copy Markdown
Contributor Author

Fiddled around with the const mkdir = denodeify(fs.mkdir); problem, couldn't get to a solution.

Following @clydin's recommendation I tried using denodeify as a generic, and doing const mkdir = denodeify<string, void>(fs.mkdir);. But this doesn't seem to be enough, the types of the callbacks don't seem to match.

I'll leave it as is for now and try to fix the typings later on.

@filipesilva
filipesilva force-pushed the ts-2.4-pr branch 9 times, most recently from 6563c6e to b203786 Compare July 21, 2017 17:27
This PR doesn't change new projects to use 2.4 since I have seen some reports of possible problems in `@angular/*`.

Instead, it:
- removes the dependency restrictions on <2.3
- bumps related dependencies to the minimum that supports 2.4 (`rxjs@^5.4.2`, `ts-node@~3.2.0`)
- builds the CLI itself using 2.4

So if you want to install ts 2.4 in your new project, the CLI itself won't stop you.

Fix angular#6827
@Brocco
Brocco merged commit 7b9fc28 into angular:master Jul 21, 2017
@kuncevic

kuncevic commented Aug 2, 2017

Copy link
Copy Markdown

interesting, angular cli supports typescript 2.4 but angular is not, yet angular/angular#18454

@filipesilva

Copy link
Copy Markdown
Contributor Author

Not so much 'supports' as 'doesn't stop you from trying to use it' :p

@filipesilva
filipesilva deleted the ts-2.4-pr branch August 2, 2017 10:28
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

typescript 2.4 support

5 participants