fix(@ngtools/webpack): don't use src dir as a resource - #7310
Merged
Conversation
Contributor
|
The Travis failure seems like a real one to me. What do you think? |
filipesilva
force-pushed
the
fix-always-rebuild
branch
from
August 10, 2017 12:01
f858fa4 to
04cb25f
Compare
Contributor
Author
|
@hansl it was real alright. Seems like a resource is still needed, so I set it to always use the gendir directory. |
We add either `src/` or `src/$$_gendir/` directories as the lazy route resource, which causes rebuilds whenever anything changes there. This PR makes it always use the `src/$$_gendir/` special directory. @Brocco this should also fix your local failing poll test. Fix angular#6238 Close angular#6959
filipesilva
force-pushed
the
fix-always-rebuild
branch
from
August 10, 2017 14:37
04cb25f to
77c60ad
Compare
Contributor
|
I think the genDir directory wouldn't be the right one in JIT mode, correct? |
Contributor
Author
|
I don't think it matters actually. We're just telling webpack there's a secret place that's the resource it should watch, but there isn't any path manipulation to be done with it. |
hansl
approved these changes
Aug 17, 2017
ghost
mentioned this pull request
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We add either
src/orsrc/$$_gendir/directories as the lazy route resource, which causes rebuilds whenever anything changes there.This PR makes it always use the
src/$$_gendir/special directory.@Brocco this should also fix your local failing poll test.
Fix #6238
Close #6959