Updated global lib story to reflect latest changes required by bootst… - #7585
Updated global lib story to reflect latest changes required by bootst…#7585adityaparab wants to merge 5 commits into
Conversation
configuration - change bootstrap link to point to latest verion - remove tether import from .angular-cli.json - update jquery path in .angular-cli.json to point to jquery.slim.js as per bootstrap documenation - update popper.js path in angular-cli.json to point to use umd verion Closes #7584
clydin
left a comment
clydin
left a comment
There was a problem hiding this comment.
Please squash the commits and update the commit message based on the guidelines found here: https://github.com/angular/angular-cli/blob/master/CONTRIBUTING.md#commit
| "../node_modules/tether/dist/js/tether.js", | ||
| "../node_modules/bootstrap/dist/js/bootstrap.js" | ||
| "../node_modules/jquery/dist/jquery.slim.js", | ||
| "../node_modules/popper.js/dist/umd/popper.js", |
There was a problem hiding this comment.
Indentation seems off. I'd suggest keeping the original two spaces.
configuration for bootstrap4 - update bootstrap url to point to current version - remove tether import from .angular-cli.json and replace it with popper.js - specify popper.js should use umd version Closes #7584
…//github.com/adityaparab/angular-cli into updated-global-lib-page-for-latest-bootstrap
|
@clydin: I'm having trouble updating commit message and then squashing commits from my machine for some reason. Closing this PR. Will open another one with your review comments implemented. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
3 participants
Will close #7584
…rap4 beta