fix(@angular/cli): add missing webpack-sources dep - #8085
Merged
Conversation
hansl
reviewed
Oct 18, 2017
hansl
left a comment
hansl
left a comment
Contributor
There was a problem hiding this comment.
We probably want ^ or ~, but not >=
filipesilva
force-pushed
the
add-webpack-sources
branch
from
October 18, 2017 15:10
cad7539 to
be33191
Compare
Contributor
Author
|
@hansl fixed. |
`license-webpack-plugin` has a peer dependency on `webpack-sources` that was being satisfied via hoisting. Fix angular#8075
filipesilva
force-pushed
the
add-webpack-sources
branch
from
October 18, 2017 15:50
be33191 to
c76985c
Compare
hansl
approved these changes
Oct 18, 2017
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
license-webpack-pluginhas a peer dependency onwebpack-sourcesthat was being satisfied via hoisting.Fix #8075