build(bazel): run aio application e2e tests under bazel

[kormide]

@gkalpak @devversion @gregmagolan @josephperrott

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• angular.io application / infrastructure changes
• Other... Please describe:

What is the new behavior?

The aio application e2e tests now run under bazel.

Does this PR introduce a breaking change?

• Yes
• No

Other information

[kormide]

Protractor depends on 12.1.7 but that version has a bug on m1 machines where the url to download the browser isn't correct.

[kormide]

@devversion I added a second commit that uses the bazel-provided chromium toolchain. It's dependent on this fix for rules_nodejs: bazel-contrib/rules_nodejs#3456. I'll update and squash once that lands.

[devversion]

This is great! thanks. Out of curiosity, could we avoid the .. thing? this is actually a short-path already and likely you would need to resolve the path using the runfile helpers?

[kormide]

The raw strings that these variables resolve to on my box are:

../org_chromium_chromedriver_linux_x64/chromedriver_linux64/chromedriver
../org_chromium_chromium_linux_x64/chrome-linux/chrome

They include a ../ which seems to already refer to a runfiles path? But they need a second ../ to counteract the chdir on this target.

Do you think I should still be using the runfile helpers?

[devversion]

does this even work on windows? on windows the runfiles are not symlinked right?

[kormide]

I tried to test this on my Windows vm but it looks like I've allowed a couple other things to regress on windows. I think I should start getting some of this running on ci, at least partially so I can check for any regressions on each PR. Are you okay with merging this as is and I'll do a Windows pass for the next PR?

[devversion]

Sounds good to me

[devversion]

does this even work on windows? on windows the runfiles are not symlinked right?

[josephperrott]

LGTM

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}