feat(ng-deploy): add option for buildTarget

[wagnermaciel]

Checklist

• Issue number for this PR: feat(ng-deploy): add option for buildTarget #2063
• Docs included?: no
• Test units included?: yes
• In a clean directory, yarn install, yarn test run successfully? yes

Description

Add an option for buildTarget so that any builder can be scheduled.

Code sample

ng deploy --buildTarget=project:browser:staging

or

"deploy": {
    "builder": "@angular/fire:deploy,
    "options": {
        "buildTarget": "project:browser:staging"
    }
}

[wagnermaciel]

Note

I'm not sure this is the best approach. Ideally ng add @angular/fire would automatically define project.architect.deploy.options.buildTarget in angular.json.

This could easily be done here schematics / ng-add.ts #L231.

Pros

We could make buildTarget required and make configuration more obvious for developers.

Cons

This could cause backwards compatibility issues.

[george43g]

Agreed, it should be automatically defined on ng add. However, backwards compatibility should be maintained ie a default fallback value.

[jamesdaniels]

LGTM, will bring into the next release this week.

[jamesdaniels]

This has been released in both 5.4 and 6.0-rc.0 FYI

[Splaktar]

Thank you for adding this! It would be great to get some documentation for it in https://github.com/angular/angularfire/blob/master/docs/deploy/getting-started.md

[Splaktar]

The description mentions using ng deploy --buildTarget=project:browser:staging, but I had to do the following to get this to work ng deploy --buildTarget=<workspace-project-name>:build:staging or ng deploy --buildTarget=<workspace-project-name>:build:production.

[mgechev]

@Splaktar feel free to open a PR with your findings to update the docs. I'll be happy to review & merge.

[george43g]

The description mentions using ng deploy --buildTarget=project:browser:staging, but I had to do the following to get this to work ng deploy --buildTarget=<workspace-project-name>:build:staging or ng deploy --buildTarget=<workspace-project-name>:build:production.

This is correct - the original description has a mistake - it's projectName:build:target - (target is production, staging, etc...)

Also, I'm assuming projectName:build falls back to the default development build.
As far as I know, there aren't any docs at all describing this feature.

PS: I've added the ability to specify a firebase project deploy target in PR #2366

EDIT: I've committed a docs update to my last pull request describing these features/options