component: MdInput by hansl · Pull Request #161 · angular/components

hansl · 2016-03-14T23:17:30Z

No description provided.

mhevery · 2016-03-15T23:18:49Z

src/core/annotations/field-value.ts

+    const defaultValue = target[key];
+
+    // Use a fallback if Symbol isn't available.
+    const localKey = isPresent(Symbol) ? Symbol(key) : `@@$_${key}`;


adding special characters such as @@ makes the object into slow object. Better to use __private_symbol_ or something like that.

Done. Firefox used to support @@ as a prefix for symbols, thus my usage of this.

ThomasBurleson · 2016-03-18T16:06:52Z

src/components/input/input.ts

+export class MdInput implements ControlValueAccessor {
+  private _empty: boolean = true;
+  private _focused: boolean = false;
+  private _onTouched: () => void = () => {};


Does ng2 provide a noop( ) function like ng1 ?

zoechi · 2016-03-22T09:31:10Z

src/components/input/README.md

+## Type
+
+At the time of writing this README, the `[type]` attribute is copied to the actual `<input>` element in the `<md-input>`. Therefore, the valid types and behavior of those are the ones supported by your browser.
+


except file?

jelbourn · 2016-03-24T18:09:06Z

src/demo-app/input/input-demo.scss

+  color: md-color($md-primary);
+}
+
+md-card {


moar .demo- prefix

jelbourn · 2016-03-24T18:12:53Z

Done w/ second pass

hansl · 2016-03-25T23:49:24Z

PTAL.

jelbourn · 2016-03-30T04:42:45Z

src/components/input/input.html

+          [class.md-accent]="dividerColor == 'accent'"></span>
+  </div>
+
+  <div *ngIf="hintLabel != ''" class="md-hint">{{hintLabel}}</div>


No actions now, but my gut is worried about each input having ~25 bindings. Something to explore later.

(I could just be clinging to Angular 1 performance concerns, though)

Noted. There should be a greater task of performance checks AND visual checking before full release. In beta maybe.

Also, https://www.youtube.com/watch?v=fpaQpyU_QiM

jelbourn · 2016-03-31T01:08:21Z

LGTM

angular-automatic-lock-bot · 2019-09-05T22:02:57Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

hansl added the in progress This issue is currently in progress label Mar 14, 2016

googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 14, 2016

hansl force-pushed the md-input branch 9 times, most recently from 2b58ce3 to de51aed Compare March 15, 2016 17:22

mhevery reviewed Mar 15, 2016
View reviewed changes

hansl force-pushed the md-input branch 3 times, most recently from 62e2d0a to 7718712 Compare March 16, 2016 19:52

jelbourn mentioned this pull request Mar 16, 2016

md-input #116

Closed

hansl force-pushed the md-input branch 4 times, most recently from b132570 to 19810be Compare March 17, 2016 18:00

ThomasBurleson reviewed Mar 18, 2016
View reviewed changes

hansl force-pushed the md-input branch 3 times, most recently from a5fa97a to a384a3a Compare March 21, 2016 17:42

zoechi reviewed Mar 22, 2016
View reviewed changes

jelbourn reviewed Mar 24, 2016
View reviewed changes

hansl force-pushed the md-input branch 7 times, most recently from 420e592 to e218b12 Compare March 25, 2016 23:28

hansl force-pushed the md-input branch 2 times, most recently from 35789d3 to c87cdb0 Compare March 29, 2016 19:04

jelbourn reviewed Mar 30, 2016
View reviewed changes

hansl force-pushed the md-input branch 4 times, most recently from 33eb683 to 3bc1606 Compare March 31, 2016 00:17

hansl force-pushed the md-input branch from 3bc1606 to 74d9bc0 Compare March 31, 2016 04:09

hansl merged commit 74d9bc0 into angular:master Mar 31, 2016

feat(): md-input

74d9bc0

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019

		## Type

		At the time of writing this README, the `[type]` attribute is copied to the actual `<input>` element in the `<md-input>`. Therefore, the valid types and behavior of those are the ones supported by your browser.

Conversation

hansl commented Mar 14, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jelbourn commented Mar 24, 2016

Uh oh!

hansl commented Mar 25, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jelbourn commented Mar 31, 2016

Uh oh!

angular-automatic-lock-bot bot commented Sep 5, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants