fix(dialog): escape key not working once element loses focus

[crisbeto]

Fixes issue in the dialog that prevented the user from being able to close via the escape key, if any of the elements inside the dialog loses focus.

Fixes #3009.

[mmalerba]

I guess we don't have access to a Renerer we can use to do this at this point in the code?

[crisbeto]

We don't. Angular only injects the renderer in components.

[abdel-ships-it]

Wouldnt it have been better to use HostListener instead?

@HostListener('document.key.Escape', ['$event']) escapeFired { this.handleEscapeKey() }

This would attach a listener on the document rather than the element, thus preventing this bug.

I am unsure why the MD team prefers the use of host over HostListener. HostListener is actually never used in the codebase. This is a perfect use case for HostListener, and I am curious on why you decided to add listeners to the document manually instead.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}