feat(select): add ability to cycle through options with arrow keys when closed#3313
Merged
Merged
Conversation
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
2990/select-arrow-selection
branch
from
7ef1e47 to
bb8ab2e
Compare
jelbourn
approved these changes
Mar 27, 2017
Contributor
jelbourn
left a comment
jelbourn
left a comment
There was a problem hiding this comment.
LGTM, one small comment. Feel free to add merge_ready when ready.
|
|
||
| // TODO(crisbeto): native selects also cycle through the options with left/right arrows, | ||
| // however the key manager only supports up/down at the moment. | ||
| this._keyManager.onKeydown(event); |
Contributor
There was a problem hiding this comment.
Add comment like
// Cycle though the select options even when the select is closed,
// matching the behavior of the native select element.
crisbeto
force-pushed
the
2990/select-arrow-selection
branch
2 times, most recently
from
73efa57 to
675a08d
Compare
Member
Author
|
Sorry for the delay on this one. Apparently I missed the notification and it also needed some refactoring after the mutli select PR got in. |
jelbourn
reviewed
Apr 11, 2017
| private _selectValue(value: any): MdOption { | ||
| let correspondingOption = this.options.find(option => option.value === value); | ||
| let optionsArray = this.options.toArray(); | ||
| let correspondingOptionIndex = optionsArray.findIndex(option => option.value === value); |
Contributor
There was a problem hiding this comment.
We can't use findIndex inside of Google (Closure's type definition for array doesn't have it).
@crisbeto ping me when this one ready again
jelbourn
added
the
presubmit failures
…en closed * Adds the ability for users to select options by focusing on a closed `md-select` and pressing the up/down arrow keys. * Fixes a bug that prevents the selection from going to the first item in a `ListKeyManager`, if there were no previously-selected items. * Adds an extra null check to the `FocusKeyManager` to avoid issues where the focused item is cleared. Fixes angular#2990.
crisbeto
force-pushed
the
2990/select-arrow-selection
branch
from
675a08d to
d90b796
Compare
Member
Author
|
Removed the |
kara
removed
the
presubmit failures
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
md-selectand pressing the up/down arrow keys.ListKeyManager, if there were no previously-selected items.FocusKeyManagerto avoid issues where the focused item is cleared.Fixes #2990.