Skip to content

fix(material/button): compute M2 icon-button density padding with CSS calc #33657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jvanderen1 wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix(material/button): compute M2 icon-button density padding with CSS calc #33657

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1fafde2
fix(material/button): compute M2 icon-button density padding with CSS…
jvanderen1 Aug 11, 2026
b0309f8
fix(material/button): wrap icon-button density padding for stylelint
jvanderen1 Aug 11, 2026
15d6309
fix(material/button): keep icon-button density padding division insid…
jvanderen1 Aug 11, 2026
dd34eac
fix(material/button): tidy icon-button density padding calc formatting
jvanderen1 Aug 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions src/material/button/_icon-button-theme.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
@use 'sass:map';
@use 'sass:math';
@use './m2-icon-button';
@use './m3-icon-button';
@use '../core/tokens/token-utils';
Expand Down Expand Up @@ -85,14 +84,12 @@
--mdc-icon-button-state-layer-size: #{$calculated-size};
--mat-icon-button-state-layer-size: #{$calculated-size};

// TODO: Switch calculated-size to "var(--mat-icon-button-state-layer-size)"
// Currently fails validation because the variable is "undefined"
// in the sass stack.
// TODO: Switch icon-size to "var(--mat-icon-button-icon-size)". Currently
// fails validation because the variable is "undefined" in the sass stack.
width: var(--mat-icon-button-state-layer-size);
height: var(--mat-icon-button-state-layer-size);
padding: math.div($calculated-size - $icon-size, 2);
padding: calc(
(var(--mat-icon-button-state-layer-size, #{$calculated-size}) -
var(--mat-icon-button-icon-size, #{$icon-size})) / 2
);
}
}
}
Expand Down