docs(Dialog): MdDialogConfig ViewContainerRef description#3747
Closed
M-a-c wants to merge 6 commits into
Closed
Conversation
I think this comment should be that large because its a rather specific definition. and is a more advanced component. Based on https://github.com/angular/material2/blob/master/src/lib/core/portal/portal.ts#L79
googlebot
added
the
cla: yes
Fixed lint. more specific, added MdDialog.open().
M-a-c
changed the title
jelbourn
reviewed
Mar 24, 2017
| /** Where the attached component should live in Angular's *logical* component tree. | ||
| * This is different from where the component *renders*, which is determined by | ||
| * the PortalHost (the component that was passed into MdDialog.open(). | ||
| * Note the origin is necessary when the host is outside of the Angular application context. */ |
Contributor
There was a problem hiding this comment.
This isn't quite right. A little more accurate would be:
/**
* Where the attached component should live in Angular's *logical* component tree.
* This affects what is available for injection and the change detection order for the
* component instantiated inside of the dialog. This does not affect where the dialog
* content will be rendered.
*/
Contributor
Author
There was a problem hiding this comment.
Yeah this makes more sense. I'll switch that out.
More accurate wording This affects what is available for injection and the change detection order for the component instantiated inside of the dialog
jelbourn
reviewed
Mar 25, 2017
| /** Where the attached component should live in Angular's *logical* component tree. | ||
| * This affects what is available for injection and the change detection order for the | ||
| * component instantiated inside of the dialog. This does not affect where the dialog | ||
| * content will be rendered. */ |
Contributor
There was a problem hiding this comment.
The JsDoc syntax isn't quite right. It goes
/**
* Line one...
* Line two...
* Line three ...
*/
Contributor
Author
|
@jelbourn LGTY? |
Contributor
Author
|
Noticed that my branches are all messed up. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3651
I looked to find an example of what this is actually used for.
I tried to explain it a little bit more. (line 2)
https://github.com/angular/material2/blob/master/src/lib/core/portal/portal.ts#L79
Does this JsDoc summary suffice?