feat(dialog): support using dialog content directives with template dialogs#9379
Merged
Merged
Conversation
googlebot
added
the
cla: yes
jelbourn
approved these changes
Jan 16, 2018
Contributor
jelbourn
left a comment
jelbourn
left a comment
There was a problem hiding this comment.
LGTM, one small comment
| if (!this.dialogRef) { | ||
| // If we couldn't get a dialog ref through DI, try to find one by looking at the DOM. | ||
| // This can happen if the close button is used inside a template dialog. Note that | ||
| // we have to do the lookup in OnInit, because the constructor might be too early. |
Contributor
There was a problem hiding this comment.
Small comment suggestion:
// When this directive is included in a dialog via TemplateRef (rather than being
// in a Component), the DialogRef isn't available via injection because embedded
// views cannot be given a custom injector. Instead, we look up the DialogRef by
// ID. This must occur in `onInit`, as the ID binding for the dialog container won't
// be resolved at constructor time.
crisbeto
force-pushed
the
5412/template-dialog-elements
branch
from
4eb16c2 to
d94efbe
Compare
crisbeto
added
action: merge
Contributor
|
@crisbeto many tests failing with |
jelbourn
added
the
presubmit failures
…ialogs Previously the `matDialogClose`, `matDialogTitle` etc. directives would only work correctly inside component dialogs, because using DI to get the dialog ref doesn't work inside template dialogs. These changes add a fallback that finds the dialog ref based on the id of the closest dialog container. Fixes angular#5412.
crisbeto
force-pushed
the
5412/template-dialog-elements
branch
from
d94efbe to
7d7d225
Compare
crisbeto
removed
the
presubmit failures
Member
Author
|
Pushed a fix for the null pointer error. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the
matDialogClose,matDialogTitleetc. directives would only work correctly inside component dialogs, because using DI to get the dialog ref doesn't work inside template dialogs. These changes add a fallback that finds the dialog ref based on the id of the closest dialog container.Fixes #5412.