This repository was archived by the owner on Apr 4, 2025. It is now read-only.
feat(@schematics/angular): remove codelyzer rules - #139
Merged
Conversation
Member
|
Yes, removing these two rules makes sense. They are related to compile-time errors handled by the compiler. |
filipesilva
approved these changes
Sep 7, 2017
Brocco
approved these changes
Sep 11, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's a copy/paste of this PR :
Few codelyzer rules report warnings which are also compile-time errors caught by the
Angular compiler and reported by the language service.
Since codelyzer doesn't aim to provide type checking and deep analysis
of the entire project, it'll be better if these two rules are removed.
Btw, soon more rules will follow mgechev/codelyzer#314.
cc/ @mgechev