This repository was archived by the owner on Mar 31, 2025. It is now read-only.
fix(base): ensure writeFile() actually writes files to disk#288
Merged
Conversation
The `mkdirp-promise` dependency had its own dependency of `"mkdirp": "*"`. But recently `mkdirp` did a new breaking change release that is no longer compatible with `mkdirp-promise`. This was causing the `writeFile()` service never to resolve its own promise, which resulted in files not getting written to the disk. This commit removes the dependency on `mkdirp-promise` since `mkdirp` now supports returning a promise directly. Fixes #287
|
yes!!!! I trace many codes and find mkdirp has changed but the mkdirp-promise not lock version. fuck....... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
mkdirp-promisedependency had its own dependency of"mkdirp": "*". But recentlymkdirpdid a new breaking changerelease that is no longer compatible with
mkdirp-promise.This was causing the
writeFile()service never to resolve its ownpromise, which resulted in files not getting written to the disk.
This commit removes the dependency on
mkdirp-promisesince
mkdirpnow supports returning a promise directly.Fixes #287