Skip to content
This repository was archived by the owner on Jan 4, 2026. It is now read-only.

feat: angular 4 compatibility#135

Merged
jelbourn merged 1 commit into
angular:masterfrom
crisbeto:ng-4
Apr 13, 2017
Merged

feat: angular 4 compatibility#135
jelbourn merged 1 commit into
angular:masterfrom
crisbeto:ng-4

Conversation

@crisbeto
Copy link
Copy Markdown
Member

@crisbeto crisbeto commented Mar 19, 2017

  • Updates all Angular dependencies to the latest RC.
  • Fixes any errors/warnings caused by the upgrade.
  • Fixes error when running the unit tests.
  • Bumps the year in the license.

Note: This depends on a release of Material that includes angular/components#3608. I've made an assumption that it'll be beta.3.

@crisbeto
Copy link
Copy Markdown
Member Author

CC @jelbourn

Copy link
Copy Markdown
Contributor

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase? I did some of this in my beta.3 PR

Comment thread package.json Outdated
@@ -1,5 +1,5 @@
{
"name": "angular-io-v42",
"name": "material-angular-io-v42",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can cut the -v42

* Updates all Angular dependencies to the latest RC.
* Fixes any errors/warnings cause by the upgrade.
* Fixes error when running the unit tests.
* Bumps the year in the license.
@crisbeto
Copy link
Copy Markdown
Member Author

crisbeto commented Apr 8, 2017

Done @jelbourn.

Edit: Not sure why the CI is failing, it seems to work locally on a clean install.

Copy link
Copy Markdown
Contributor

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit 1bccf71 into angular:master Apr 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants