This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(tooltip): changing direction causes invalid position#11087
Merged
mmalerba merged 1 commit intoFeb 6, 2018
Conversation
Providing the initial origin through the `panelClass` of the panel is not the right approach. `mdPanel` remembers the original panel configuration and the provided `panelClass` and will restore it when the element is reused. This results in the new origin and the default (bottom) origin style to be placed on the element. Fixes #10405
Splaktar
approved these changes
Jan 27, 2018
Contributor
Splaktar
left a comment
There was a problem hiding this comment.
LGTM. Manual tests successful.
Contributor
|
This is failing the Google presubmit tests. So far any information that I have been given seems to indicate that the failure is a "flake", i.e. completely unrelated to this change. I am continuing to work with and push for this fix to get in as I don't want to release 1.1.7 without it. |
Contributor
Author
|
Awesome. Happy to see this merged :) Well done |
chmelevskij
pushed a commit
to chmelevskij/material
that referenced
this pull request
Jun 19, 2018
Providing the initial origin through the `panelClass` of the panel is not the right approach. `mdPanel` remembers the original panel configuration and the provided `panelClass` and will restore it when the element is reused. This results in the new origin and the default (bottom) origin style to be placed on the element. Fixes angular#10405
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Providing the initial origin through the
panelClassof the panel is not the right approach.mdPanelremembers the original panel configuration and the providedpanelClassand will restore it when the element is reused. This results in the new origin and the default (bottom) origin style to be placed on the element at the same time.Fixes #10405
PR Checklist
Please check that your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When the direction of a tooltip is changed, the resulting position will not be correctly applied, resulting in off-center placement of tooltips.
Issue Number: #10405
What is the new behavior?
The tooltip is correctly positioned after the direction was adjusted.
Does this PR introduce a breaking change?