You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 5, 2024. It is now read-only.
👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.
😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.
Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.
googlebot
added
the
cla: no
PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/
label
Jul 20, 2018
Splaktar
added
in progress
Mainly for in progress PRs, but may be used for issues that require multiple PRs
type: bug
ui: theme
P1: urgent
Urgent issues that should be addressed in the next minor or patch release.
a11y
This issue is related to accessibility
g3: reported
The issue was reported by an internal or external product team.
labels
Jul 20, 2018
Splaktar
added
the
Blocked
Progress on this issue is blocked. Primarily used for PRs that are blocked by presubmit feedback.
label
Aug 26, 2019
Splaktar
changed the title
WIP: fix(toolbar): input placeholders and ink need more contrast
fix(toolbar): input placeholders and ink need more contrast
Aug 26, 2019
Splaktar
removed
the
in progress
Mainly for in progress PRs, but may be used for issues that require multiple PRs
label
Aug 26, 2019
PR #11953 builds upon this and improves toolbar and input theming a bit more.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
a11yThis issue is related to accessibilitycla: yesPR author has signed Google's CLA: https://opensource.google.com/docs/cla/g3: reportedThe issue was reported by an internal or external product team.P1: urgentUrgent issues that should be addressed in the next minor or patch release.pr: lgtmThis PR has been approved by the reviewerpr: merge readyThis PR is ready for a caretaker to reviewtype: bugui: theme
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check that your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Inputs in toolbars aren't themed properly and don't meet a11y guidelines for contrast.
Issue Number:
Fixes #7987. This depends on #11376 being merged first.
What is the new behavior?
Inputs in toolbars are themed properly and have contrast to make them readable.
Does this PR introduce a breaking change?
Other information
Before

After
