NumberExtensions should not use Convert for net7.0

[lipchev]

I just noticed this simple performance improvement that's likely to have a huge performance impact on the NumberExtensions..

        public static Mass Centigrams<T>(this T value)
            where T : notnull
#if NET7_0_OR_GREATER
            , INumber<T>
            => Mass.FromCentigrams(double.CreateChecked(value));
#else
            => Mass.FromCentigrams(Convert.ToDouble(value));
#endif

Not sure if we want this in v5, v6 or I could just put it up-for-grabs and leave it for later..

Note that there is probably a Convert.ToDecimal somewhere, just waiting to popup as a merge conflict...

[lipchev]

@angularsen Oh you're gonna love this: thanks to the IConvertible interface, on net48- the following syntax should work just fine: Mass newMass = Mass.FromGrams(2).Centigrams() 😆 (of course this would be wrong)

[angularsen]

Let's not bother with v5, it can receive new units and bug fixes, but new features can mostly just go into v6 so we can focus on finalizing and shipping it before it becomes an infinite project. Scope is definitely creeping.

As for net48, I can sympathize being stuck on a legacy project, but come on! Get on with the times people! .NET Core 2.x has been available for 6 years already 😅

Good example though, something to consider when discussing IConvertible.

My current thinking is, if the argument is WPF and XAML-like bindings, then value converters are a better approach than requiring all quantities to implement IConvertible.

public class FooTests
{
#if NET48
        [Fact]
        public void Foo()
        {
            Mass newMass = NumberToMassExtensions.Kilograms(Mass.FromGrams(2000));
            Assert.Equal(Mass.FromKilograms(2), newMass);
            /*
            Assert.Equal() Failure: Values differ
            Expected: 2 kg
            Actual:   2000 kg
            */
        }
#endif

}

[angularsen]

Regarding the issue description, sounds good to me 👍

[Muximize]

FYI, getting rid of IConvertible would clean up 99 lines of code in each of 126 quantities for a total of 12.474 lines removed.

[github-actions]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

[angularsen]

Move on, nothing to see here bot

[andrewimcclement]

@angularsen this issue should presumably be closed?

[angularsen]

Right, thanks!

Fixed in #1518 for v6